Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): allow tags to be applied in bulk on search, personID, and memory-viewer pages #14368

Merged
merged 4 commits into from
Dec 11, 2024
Merged

feat(web): allow tags to be applied in bulk on search, personID, and memory-viewer pages #14368

merged 4 commits into from
Dec 11, 2024

Conversation

Menghini
Copy link
Contributor

@Menghini Menghini commented Nov 26, 2024 •
edited by alextran1502
Loading

I have been adding a lot of tags to my photos on my Immich server to help organize photos. However, when I try to add tags based upon a PersonID or when using the search function, I am forced right now to add it to a temporary album and then open the album to then apply the tag. This PR would solve that issue.

Close #14106

@Menghini
Copy link
Contributor Author

Menghini commented Nov 27, 2024 •
edited
Loading

This PR would implement Feature Request #14106.

Although #14213 added some great features, it still was missing the tag option in the menu.

@danieldietzler danieldietzler changed the title Allow Tags To Be Applied In Bulk On Search and PersonID Pages feat: Allow Tags To Be Applied In Bulk On Search and PersonID Pages Nov 27, 2024
@danieldietzler
Copy link
Member

Please fix the formatting errors

@Menghini
Copy link
Contributor Author

Please fix the formatting errors

Should be fixed now, I believe.

@Menghini Menghini changed the title feat: Allow Tags To Be Applied In Bulk On Search and PersonID Pages feat: Allow Tags To Be Applied In Bulk On Search, PersonID, Memory-Viewer Pages Nov 28, 2024
@Menghini
Copy link
Contributor Author

Now also includes the Memory-Viewer page as well.

@Menghini Menghini changed the title feat: Allow Tags To Be Applied In Bulk On Search, PersonID, Memory-Viewer Pages feat: Allow Tags To Be Applied In Bulk On Search, PersonID, and Memory-Viewer Pages Nov 28, 2024
danieldietzler
danieldietzler approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 changed the title feat: Allow Tags To Be Applied In Bulk On Search, PersonID, and Memory-Viewer Pages feat(web): allow tags to be applied in bulk on search, personID, and memory-viewer pages Dec 11, 2024
@alextran1502 alextran1502 merged commit e40c7c5 into immich-app:main Dec 11, 2024
37 checks passed
@Hixxey
Copy link

Hixxey commented Dec 13, 2024

I have tags enabled and I am the owner of all the images in the library but I cannot see the tag search. Am I missing something? Does this feature not work with external libraries?

@Menghini
Copy link
Contributor Author

I have tags enabled and I am the owner of all the images in the library but I cannot see the tag search. Am I missing something? Does this feature not work with external libraries?

This PR allows you to add a tag to a bulk of images that was on the search, personID, and memory-viewer pages, but doesn't cover the /tag page. Right now, as far as I know, the /tag page doesn't have any controls or search.

@Hixxey
Copy link

Hixxey commented Dec 13, 2024

I have tags enabled and I am the owner of all the images in the library but I cannot see the tag search. Am I missing something? Does this feature not work with external libraries?

This PR allows you to add a tag to a bulk of images that was on the search, personID, and memory-viewer pages, but doesn't cover the /tag page. Right now, as far as I know, the /tag page doesn't have any controls or search.

Got it, thank you. I misunderstood the PR

yosit pushed a commit to yosit/immich that referenced this pull request Dec 20, 2024
@Menghini @yosit
feat(web): allow tags to be applied in bulk on search, personID, and …
71f5261 
…memory-viewer pages (immich-app#14368)

* Allow Tags to be applied in bulk on search page

* Added Tags Action To PersonID Page

* Fixed Formatting Issues

* Added Tags Option to Memory-Viewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
changelog:enhancement 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Menghini @danieldietzler @Hixxey @alextran1502 @michelheusschen